Separate out tests for the GPL build and do not run them when GPL libs are not present #658
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ViralBShah
force-pushed
the
vs/gpl_tests
branch
from
1badb9c to
0cd1754
Compare
…raries are not present. Fix #655
ViralBShah
force-pushed
the
vs/gpl_tests
branch
from
0cd1754 to
2c6b38f
Compare
ViralBShah
added
backport 1.12
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #658 +/- ##
==========================================
+ Coverage 84.07% 84.17% +0.09%
==========================================
Files 12 12
Lines 9300 9300
==========================================
+ Hits 7819 7828 +9
+ Misses 1481 1472 -9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
This was merged after the v1.13 split. Should this be backported? |
Member
Author
|
Yes, let's backport. |
dkarrasch
pushed a commit
that referenced
this pull request
Dec 24, 2025
…s are not present (#658) Fix #655 The tests marked broken in this PR seem to be an unfortunate regression that doesn't have to do with this PR. @jishnub This seems to have to do with methods that multiply a SparseMatrixCSC with a Diagonal and the behaviour seems right in 1.10, but not in 1.11 and 1.12. --------- Co-authored-by: Viral B. Shah <ViralBShah@users.noreply.github.com>
|
@dkarrasch could this also be ported to 1.12? I'm trying to get a no-gpl release and this blocks that |
dkarrasch
pushed a commit
that referenced
this pull request
Jan 15, 2026
…s are not present (#658) Fix #655 The tests marked broken in this PR seem to be an unfortunate regression that doesn't have to do with this PR. @jishnub This seems to have to do with methods that multiply a SparseMatrixCSC with a Diagonal and the behaviour seems right in 1.10, but not in 1.11 and 1.12. --------- Co-authored-by: Viral B. Shah <ViralBShah@users.noreply.github.com>
Member
|
Sure. Sorry I missed the backport label in my last backport PR. |
dkarrasch
added a commit
that referenced
this pull request
Jan 15, 2026
Member
|
Do we also need a v1.11 backport? I thought we're not releasing in that cycle anymore, but I do see some backport activity over at JuliaLang/julia#60692. |
dkarrasch
added a commit
that referenced
this pull request
Jan 15, 2026
Member
Author
|
I think it would certainly be useful. |
dkarrasch
pushed a commit
that referenced
this pull request
Jan 16, 2026
…s are not present (#658) Fix #655 The tests marked broken in this PR seem to be an unfortunate regression that doesn't have to do with this PR. @jishnub This seems to have to do with methods that multiply a SparseMatrixCSC with a Diagonal and the behaviour seems right in 1.10, but not in 1.11 and 1.12. --------- Co-authored-by: Viral B. Shah <ViralBShah@users.noreply.github.com>
dkarrasch
added a commit
that referenced
this pull request
Jan 21, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #655
The tests marked broken in this PR seem to be an unfortunate regression that doesn't have to do with this PR. @jishnub This seems to have to do with methods that multiply a SparseMatrixCSC with a Diagonal and the behaviour seems right in 1.10, but not in 1.11 and 1.12.