Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move fkeep! docstring to the right function #503

Merged
merged 2 commits into from
Feb 8, 2024

Conversation

lgoettgens
Copy link
Contributor

Handles the SparseArrays part of JuliaLang/julia#52725.

The docstring was already there, it was just attached to the wrong function.

In which file should I put the test?

@test Docs.undocumented_names(SparseArrays) == []

cc @stevengj

Copy link

codecov bot commented Feb 6, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (67c20a8) 85.00% compared to head (46a4709) 85.00%.
Report is 4 commits behind head on main.

Files Patch % Lines
src/solvers/wrappers.jl 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #503      +/-   ##
==========================================
- Coverage   85.00%   85.00%   -0.01%     
==========================================
  Files          12       12              
  Lines        8959     8967       +8     
==========================================
+ Hits         7616     7622       +6     
- Misses       1343     1345       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stevengj
Copy link
Contributor

stevengj commented Feb 6, 2024

I would just put the test in the top-level file https://github.com/JuliaSparse/SparseArrays.jl/blob/main/test/runtests.jl

@rayegun
Copy link
Member

rayegun commented Feb 6, 2024

Can you put it in issues.jl with a link back to the original issue in Julialang? I will merge as soon as that's done

@lgoettgens
Copy link
Contributor Author

Can you put it in issues.jl with a link back to the original issue in Julialang? I will merge as soon as that's done

Done. The windows CI failure seems to be unrelated.

@rayegun rayegun merged commit 1748989 into JuliaSparse:main Feb 8, 2024
4 of 8 checks passed
@lgoettgens lgoettgens deleted the lg/doc-fkeep branch February 8, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants