Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in source code #391

Merged
merged 1 commit into from
May 13, 2023
Merged

Fix typo in source code #391

merged 1 commit into from
May 13, 2023

Conversation

LilithHafner
Copy link
Member

@LilithHafner LilithHafner commented May 13, 2023

This fixes a typo that was causing #390. (Oops, looks like we need more test coverage :) )

Fixes #390

@codecov
Copy link

codecov bot commented May 13, 2023

Codecov Report

Merging #391 (4c36487) into main (0773db8) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #391      +/-   ##
==========================================
+ Coverage   93.86%   93.92%   +0.05%     
==========================================
  Files          12       12              
  Lines        7484     7484              
==========================================
+ Hits         7025     7029       +4     
+ Misses        459      455       -4     
Impacted Files Coverage Δ
src/sparsematrix.jl 95.47% <100.00%> (+0.16%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@rayegun rayegun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

x86 failures are unrelated, I'll give the repo a test coverage pass once classes are done

@LilithHafner LilithHafner merged commit 7df375c into main May 13, 2023
@LilithHafner LilithHafner deleted the fix-typo-390 branch May 13, 2023 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

swapcols! is wrong on sparse matrices
2 participants