Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make arwheadnlp.f(x) allocation-free #241

Merged
merged 1 commit into from
Dec 19, 2022
Merged

Make arwheadnlp.f(x) allocation-free #241

merged 1 commit into from
Dec 19, 2022

Conversation

paraynaud
Copy link
Member

@tmigot, following this discussion.

@paraynaud paraynaud requested a review from tmigot December 19, 2022 17:09
@codecov
Copy link

codecov bot commented Dec 19, 2022

Codecov Report

Base: 99.79% // Head: 99.68% // Decreases project coverage by -0.10% ⚠️

Coverage data is based on head (dcc4281) compared to base (51b27d7).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #241      +/-   ##
==========================================
- Coverage   99.79%   99.68%   -0.11%     
==========================================
  Files         793      793              
  Lines        7335     7342       +7     
==========================================
- Hits         7320     7319       -1     
- Misses         15       23       +8     
Impacted Files Coverage Δ
src/ADNLPProblems/arwhead.jl 100.00% <100.00%> (ø)
src/ADNLPProblems/polygon2.jl 83.33% <0.00%> (-16.67%) ⬇️
src/ADNLPProblems/hs36.jl 84.61% <0.00%> (-15.39%) ⬇️
src/ADNLPProblems/hs37.jl 84.61% <0.00%> (-15.39%) ⬇️
src/ADNLPProblems/hs44.jl 84.61% <0.00%> (-15.39%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@tmigot tmigot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @paraynaud
Good catch

@tmigot tmigot merged commit 2c75b90 into main Dec 19, 2022
@tmigot tmigot deleted the pr-arwhead-allocfree branch December 19, 2022 22:47
@paraynaud
Copy link
Member Author

@tmigot I tested grad! for this new arwhead, you will be happy to know that it doen't make allocations, contrary to the previous version!

@tmigot
Copy link
Member

tmigot commented Dec 20, 2022

Awesome!

@tmigot
Copy link
Member

tmigot commented Jan 10, 2023

Connected to #243

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants