Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate 5-args constructor #282

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

geoffroyleconte
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Jul 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8a4bba3) 96.57% compared to head (8f52b9b) 96.48%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #282      +/-   ##
==========================================
- Coverage   96.57%   96.48%   -0.09%     
==========================================
  Files          15       15              
  Lines        1051     1053       +2     
==========================================
+ Hits         1015     1016       +1     
- Misses         36       37       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2023

Package name latest stable
CaNNOLeS.jl
DCISolver.jl
FletcherPenaltySolver.jl
JSOSolvers.jl
Krylov.jl
NLPModels.jl
NLPModelsModifiers.jl
PROPACK.jl
Percival.jl
QuadraticModels.jl
SolverTools.jl

@geoffroyleconte
Copy link
Member Author

geoffroyleconte commented Jul 7, 2023

I needed to remove the constructor LinearOperator{T}(.....) and replace it with LinearOperator(::Type{T}, ....) where {T} because it would not work for LinearOperator5{T}(......), but this is a breaking change.

@dpo dpo closed this Dec 5, 2023
@dpo dpo reopened this Dec 5, 2023
@dpo
Copy link
Member

dpo commented Dec 5, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants