Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@turbo check_empty=true in most all cases #29

Merged
merged 1 commit into from
May 13, 2023
Merged

@turbo check_empty=true in most all cases #29

merged 1 commit into from
May 13, 2023

Conversation

brenhinkeller
Copy link
Collaborator

To prevent equivalents of NaNStatistics#35

@chriselrod
Copy link
Member

We could make that the default in LV if it's such a footgun.

@brenhinkeller brenhinkeller merged commit 6d8fc6d into main May 13, 2023
@brenhinkeller brenhinkeller deleted the check-empty branch May 13, 2023 17:40
@brenhinkeller
Copy link
Collaborator Author

Oh that's a good question.. how much is the performance cost? If it's basically just a single if I'd say go for it!

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brenhinkeller @chriselrod