-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create vsum
#496
Create vsum
#496
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #496 +/- ##
==========================================
- Coverage 86.78% 85.65% -1.13%
==========================================
Files 39 39
Lines 9524 9524
==========================================
- Hits 8265 8158 -107
- Misses 1259 1366 +107
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure.
If people want much more than this, it might also be good to point people to:
https://github.com/andrewjradcliffe/VectorizedReduction.jl
https://github.com/JuliaSIMD/VectorizedStatistics.jl
You need to export |
Fixed, thanks. That package looks super useful, I didn’t know about it. It might be a good idea to ask and try to bring it under the JuliaSIMD organization, for consistency and long term support. I think having it seem like a more “official” package would make me more likely to use it. |
Oh I didn’t know about VectorizedStatistics! Should I close this PR? |
@andrewjradcliffe you're welcome to move your package to JuliaSIMD if you'd like. |
This creates a vectorized version of
sum
, as has been done withvmapreduce
andvreduce
already. The implementation is just an alias:(There is a
vsum
in VectorizationBase.jl; that one is I think (?) an internal utility, as it doesn't take normal arrays.)For example: