Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 16 bits to store an array reference index #451

Merged

Conversation

johnbcoughlin
Copy link
Contributor

This seems to work without causing any extra errors, hopefully CI bears it out.

@chriselrod
Copy link
Member

Thanks. I guess you've confirmed this fixes your problem locally?

If it's not too much trouble, mind adding a test?

Also, please feel free to bump the patch version so I can issue a new release after merging.

@codecov
Copy link

codecov bot commented Dec 28, 2022

Codecov Report

Base: 86.16% // Head: 86.78% // Increases project coverage by +0.62% 🎉

Coverage data is based on head (1b404b2) compared to base (c74cd33).
Patch coverage: 75.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #451      +/-   ##
==========================================
+ Coverage   86.16%   86.78%   +0.62%     
==========================================
  Files          37       38       +1     
  Lines        9379     9390      +11     
==========================================
+ Hits         8081     8149      +68     
+ Misses       1298     1241      -57     
Impacted Files Coverage Δ
src/condense_loopset.jl 96.44% <75.00%> (+1.18%) ⬆️
src/getconstindexes.jl 25.00% <0.00%> (-75.00%) ⬇️
src/LoopVectorization.jl 50.00% <0.00%> (-16.67%) ⬇️
src/simdfunctionals/mapreduce.jl 82.79% <0.00%> (-9.68%) ⬇️
src/codegen/lower_constant.jl 73.23% <0.00%> (-1.88%) ⬇️
src/reconstruct_loopset.jl 91.79% <0.00%> (-0.79%) ⬇️
src/precompile.jl 0.00% <0.00%> (ø)
src/codegen/lower_compute.jl 88.03% <0.00%> (+0.23%) ⬆️
src/codegen/lower_memory_common.jl 86.59% <0.00%> (+0.36%) ⬆️
src/codegen/lower_store.jl 88.00% <0.00%> (+0.44%) ⬆️
... and 14 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@johnbcoughlin johnbcoughlin force-pushed the johnbcoughlin/increase-array-ref-limit branch from 45678ea to 8dabcfa Compare December 28, 2022 14:40
@johnbcoughlin
Copy link
Contributor Author

Done. The new test fails on master with the same error. Let me know if you'd like me to test a more general property now that the 8 bit limit is raised.

@johnbcoughlin johnbcoughlin force-pushed the johnbcoughlin/increase-array-ref-limit branch from 9f11e74 to 0cf3e7e Compare December 28, 2022 14:54
Jack Coughlin added 2 commits December 28, 2022 10:34
- Add test with generated function
- Use 16 bits to store an array reference index
@johnbcoughlin johnbcoughlin force-pushed the johnbcoughlin/increase-array-ref-limit branch from 0cf3e7e to 1b404b2 Compare December 28, 2022 18:34
Copy link
Member

@chriselrod chriselrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks great!

@chriselrod chriselrod enabled auto-merge (squash) December 30, 2022 07:01
@chriselrod chriselrod merged commit 35f8310 into JuliaSIMD:main Dec 30, 2022
@chriselrod
Copy link
Member

Failures are unrelated to this PR.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants