-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use 16 bits to store an array reference index #451
Use 16 bits to store an array reference index #451
Conversation
Thanks. I guess you've confirmed this fixes your problem locally? If it's not too much trouble, mind adding a test? Also, please feel free to bump the patch version so I can issue a new release after merging. |
Codecov ReportBase: 86.16% // Head: 86.78% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #451 +/- ##
==========================================
+ Coverage 86.16% 86.78% +0.62%
==========================================
Files 37 38 +1
Lines 9379 9390 +11
==========================================
+ Hits 8081 8149 +68
+ Misses 1298 1241 -57
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
45678ea
to
8dabcfa
Compare
Done. The new test fails on master with the same error. Let me know if you'd like me to test a more general property now that the 8 bit limit is raised. |
9f11e74
to
0cf3e7e
Compare
- Add test with generated function - Use 16 bits to store an array reference index
0cf3e7e
to
1b404b2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks great!
Failures are unrelated to this PR. |
This seems to work without causing any extra errors, hopefully CI bears it out.