-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
let homogeneous tuples be alldense
#445
Conversation
This lets LoopVectorization work more broadly .. e.g. VectorizedStatistics can process NTuples, `vminimum((1.0,2.0,0.5,1.5))` (currently it chokes).
Codecov ReportBase: 86.16% // Head: 86.15% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #445 +/- ##
==========================================
- Coverage 86.16% 86.15% -0.01%
==========================================
Files 37 37
Lines 9376 9378 +2
==========================================
+ Hits 8079 8080 +1
- Misses 1297 1298 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
clearly I overlooked something structural -- closing this PR |
What did you overlook? Is this not enough for the example |
It does make the v_ functions work -- what I overlooked is whatever is causing the test to fail here |
That is fixed by my suggestion above. |
I went ahead and committed my suggestion; I'll merge if tests pass. |
This lets LoopVectorization work more broadly .. e.g. VectorizedStatistics can process NTuples,
vminimum((1.0,2.0,0.5,1.5))
(currently it chokes).