Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

let homogeneous tuples be alldense #445

Merged
merged 2 commits into from
Nov 21, 2022

Conversation

JeffreySarnoff
Copy link
Contributor

This lets LoopVectorization work more broadly .. e.g. VectorizedStatistics can process NTuples, vminimum((1.0,2.0,0.5,1.5)) (currently it chokes).

This lets LoopVectorization work more broadly .. e.g. VectorizedStatistics can process NTuples, `vminimum((1.0,2.0,0.5,1.5))` (currently it chokes).
@codecov
Copy link

codecov bot commented Nov 21, 2022

Codecov Report

Base: 86.16% // Head: 86.15% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (4d7904e) compared to base (e5189a8).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #445      +/-   ##
==========================================
- Coverage   86.16%   86.15%   -0.01%     
==========================================
  Files          37       37              
  Lines        9376     9378       +2     
==========================================
+ Hits         8079     8080       +1     
- Misses       1297     1298       +1     
Impacted Files Coverage Δ
src/simdfunctionals/map.jl 92.13% <0.00%> (-0.48%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@JeffreySarnoff
Copy link
Contributor Author

clearly I overlooked something structural -- closing this PR
will open an issue covering the same thing

@chriselrod
Copy link
Member

clearly I overlooked something structural -- closing this PR will open an issue covering the same thing

What did you overlook? Is this not enough for the example vminimum to work?

@JeffreySarnoff
Copy link
Contributor Author

It does make the v_ functions work -- what I overlooked is whatever is causing the test to fail here
https://github.com/JuliaSIMD/LoopVectorization.jl/actions/runs/3512452079/jobs/5884165315
If that is unrelated -- cool.

@chriselrod
Copy link
Member

It does make the v_ functions work -- what I overlooked is whatever is causing the test to fail here https://github.com/JuliaSIMD/LoopVectorization.jl/actions/runs/3512452079/jobs/5884165315 If that is unrelated -- cool.

That is fixed by my suggestion above.

@chriselrod chriselrod enabled auto-merge (squash) November 21, 2022 19:33
@chriselrod
Copy link
Member

I went ahead and committed my suggestion; I'll merge if tests pass.

@chriselrod chriselrod merged commit 943e35d into JuliaSIMD:main Nov 21, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants