Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing csm on multiple features test #191

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Conversation

dehann
Copy link
Member

@dehann dehann commented Sep 26, 2019

EDIT: better to consolidate this effort with:

@dehann dehann added this to the v0.4.x milestone Sep 26, 2019
@dehann dehann modified the milestones: v0.4.x, v0.5.x Nov 20, 2019
@codecov-io
Copy link

codecov-io commented Mar 14, 2020

Codecov Report

Merging #191 into master will decrease coverage by 3.24%.
The diff coverage is 57.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #191      +/-   ##
==========================================
- Coverage   23.75%   20.51%   -3.25%     
==========================================
  Files          30       36       +6     
  Lines        1486     1711     +225     
==========================================
- Hits          353      351       -2     
- Misses       1133     1360     +227     
Impacted Files Coverage Δ
src/RoME.jl 100.00% <ø> (ø)
src/factors/DynPoint2D.jl 50.00% <0.00%> (+1.02%) ⬆️
src/factors/Pose2D.jl 63.63% <ø> (+5.57%) ⬆️
src/factors/Bearing2D.jl 30.00% <50.00%> (-5.30%) ⬇️
src/factors/BearingRange2D.jl 51.72% <100.00%> (-30.63%) ⬇️
src/factors/MultipleFeaturesConstraint.jl 0.00% <0.00%> (-85.97%) ⬇️
src/factors/Point2D.jl 53.70% <0.00%> (-9.34%) ⬇️
src/factors/Range2D.jl 29.62% <0.00%> (-5.16%) ⬇️
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98bcda0...1933573. Read the comment docs.

@dehann
Copy link
Member Author

dehann commented Oct 21, 2020

@Affie here is a fun test that used to work way back but broke with CSM at some point. This might already work again, and probably a good stress test while CSM is being updated -- don't let it distract if it's too far out. been commented out for about a year. It's an important test to bring back in the long run though.

@dehann
Copy link
Member Author

dehann commented Oct 21, 2020

ah wait this still needs the multihypo= keyword update. Don't add it just yet. good to look at for reference in the mean time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants