Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix julia 1.8 bug on tree deepcopy #1601

Merged
merged 5 commits into from
Aug 19, 2022
Merged

Fix julia 1.8 bug on tree deepcopy #1601

merged 5 commits into from
Aug 19, 2022

Conversation

Affie
Copy link
Member

@Affie Affie commented Aug 18, 2022 •
edited
Loading

close #1530

This patch might only be temporary if it is indeed a julia bug.

@Affie Affie added the bug fix label Aug 18, 2022
@Affie Affie added this to the v0.30.5 milestone Aug 18, 2022
@Affie Affie self-assigned this Aug 18, 2022
@Affie Affie marked this pull request as draft August 18, 2022 19:32
@codecov
Copy link

codecov bot commented Aug 18, 2022 •
edited
Loading

Codecov Report

Merging #1601 (85dc2e8) into master (96fff67) will increase coverage by 0.10%.
The diff coverage is 94.11%.

@@            Coverage Diff             @@
##           master    #1601      +/-   ##
==========================================
+ Coverage   77.73%   77.83%   +0.10%     
==========================================
  Files          73       73              
  Lines        5102     5392     +290     
==========================================
+ Hits         3966     4197     +231     
- Misses       1136     1195      +59
Impacted Files Coverage Δ
src/entities/JunctionTreeTypes.jl 94.73% <94.11%> (-5.27%) ⬇️
...iqueStateMachine/services/CliqStateMachineUtils.jl 79.71% <0.00%> (-1.54%) ⬇️
src/services/BayesNet.jl 67.04% <0.00%> (-0.86%) ⬇️
src/services/CompareUtils.jl 15.00% <0.00%> (-0.79%) ⬇️
.../CliqueStateMachine/services/CliqueStateMachine.jl 90.47% <0.00%> (-0.76%) ⬇️
src/services/FGOSUtils.jl 71.25% <0.00%> (-0.72%) ⬇️
src/services/CliqueTypes.jl 65.30% <0.00%> (-0.66%) ⬇️
src/NeedsResolution.jl 7.14% <0.00%> (-0.55%) ⬇️
src/services/JunctionTreeUtils.jl 86.59% <0.00%> (-0.36%) ⬇️
src/services/TreeMessageUtils.jl 85.77% <0.00%> (-0.20%) ⬇️
... and 29 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Affie Affie mentioned this pull request Aug 19, 2022
Closed
@Affie Affie marked this pull request as ready for review August 19, 2022 10:26
@Affie Affie requested a review from dehann August 19, 2022 12:52
dehann
dehann approved these changes Aug 19, 2022
View reviewed changes
Copy link
Member

@dehann dehann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Affie Affie merged commit 6426e80 into master Aug 19, 2022
dehann added a commit that referenced this pull request Sep 11, 2022
@dehann
restore jl deepcopy_interal #1530 and #1601
914e257
dehann added a commit that referenced this pull request Sep 11, 2022
@dehann
Merge pull request #1629 from JuliaRobotics/22Q3/depr/jl19fix
7af4026 
restore jl deepcopy_interal #1530 and #1601
@dehann dehann deleted the 22Q3/bugfix/deepcopytree branch November 27, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dehann dehann dehann approved these changes

Assignees

@Affie Affie

Labels
bug fix julia version upstream
Projects
None yet
Milestone
v0.30.5
Development

Successfully merging this pull request may close these issues.

MethodError: no method matching deepcopy_internal on julia 1.8 rc1
2 participants
@Affie @dehann