-
-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added first Independent Q Learning experiment #922
base: main
Are you sure you want to change the base?
added first Independent Q Learning experiment #922
Conversation
Codecov Report
@@ Coverage Diff @@
## main #922 +/- ##
========================================
+ Coverage 0.02% 0.04% +0.01%
========================================
Files 215 209 -6
Lines 7622 7421 -201
========================================
+ Hits 2 3 +1
+ Misses 7620 7418 -202
|
src/ReinforcementLearningExperiments/src/experiments/MARL/IDQN_TicTacToe.jl
Outdated
Show resolved
Hide resolved
@HenriDeh, @jeremiahpslewis would you have a look? It is supposed to just be an example on how to use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see a problem with the implementation but it needs to be added to the tests of RLExperiments like the other ones are. Otherwise we may not see that a change breaks this example and it will live there broken until someone notices.
I this what you intended to say here @HenriDeh ? Commit 82f77f4 |
adjusted tests and merged main
a7eedd7
to
d660085
Compare
FYI: rebased commit structure as it was messed up. |
adjusted tests and merged main
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes thank you. Gotta figure out why the CI fails now.
adjusted tests and merged main
Finally, the pipeline should be correct. I needed to add some parts, but this is also helpful for other 3rd party environments once they need to be tested. |
this should be solved now @HenriDeh ? |
Hi @Mytolo, sorry for the delay, I was on vacations. You have conflicts to resolve then I can approve the PR for merging :) |
PR Checklist
Here is an experiment for RLExperiments showing how to set up a simple independent learning with two players. (In the example, the roles of randomly choosing an action and taking create_policy -> DQN can be changed and they can also both try to approximate their Q values for action selection)