Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note about RLZoo deprecation #1062

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

jeremiahpslewis
Copy link
Member

PR Checklist

  • Update NEWS.md?
  • Unit tests for all structs / functions?
  • Integration and correctness tests using a simple env?
  • PR Review?
  • Add or update documentation?
  • Write docstrings for new methods?

Copy link

codecov bot commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 1.12%. Comparing base (d470d48) to head (1684215).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #1062       +/-   ##
==========================================
- Coverage   32.35%   1.12%   -31.23%     
==========================================
  Files          73      73               
  Lines        2785    2748       -37     
==========================================
- Hits          901      31      -870     
- Misses       1884    2717      +833     

see 32 files with indirect coverage changes

Copy link
Member

@HenriDeh HenriDeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can add an @warn in the __init__ method of the package. This way users will be warned when loading it.

@jeremiahpslewis
Copy link
Member Author

@HenriDeh What about an @info when loading RL.jl?

@HenriDeh
Copy link
Member

That also works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants