fixed findmax unconsistency (#521)

* fixed Base.findmax unconsistency * Update src/ReinforcementLearningCore/src/utils/base.jl Co-authored-by: Jun Tian <[email protected]> Co-authored-by: Jun Tian <[email protected]>
JuliaReinforcementLearning · Oct 8, 2021 · c6c5053 · c6c5053
1 parent e2c4673
commit c6c5053
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/src/ReinforcementLearningCore/src/utils/base.jl b/src/ReinforcementLearningCore/src/utils/base.jl
@@ -149,8 +149,7 @@ end
 # _rf_findmax((fm, m), (fx, x)) = isless(fm, fx) ? (fx, x) : (fm, m)
 
 # !!! type piracy
-Base.findmax(A::AbstractVector, mask::AbstractVector{Bool}) =
-    findmax(i -> A[i], view(keys(A), mask))
+Base.findmax(A::AbstractVector{T}, mask::AbstractVector{Bool}) where T = findmax(ifelse.(mask, A, typemin(T)))
 
 
 const VectorOrMatrix = Union{AbstractMatrix,AbstractVector}