Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev #16

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Dev #16

wants to merge 8 commits into from

Conversation

the-one-and-only-jackson
Copy link

Changes here beyond fixes:

  • ArraySpace is no longer just an alias for ReapeatedSpace. If the base space is an AbstractFloat, instead a Box is constructed.
  • Box allows random sampling on infinite and semi-infinite intervals similar to gymnasium.
  • The product of a finite and continuous space now identifies as a HybridSpaceStyle rather than UnknownSpaceStyle.

@the-one-and-only-jackson
Removed redundant argument type
605d663 
AbstractRange isa AbstractArray
@the-one-and-only-jackson
Update to RepeatedSpace and ArraySpace
462a7bc 
ArraySpace now constructs either a ReapeatedSpace or Box based on the base_space.
@the-one-and-only-jackson
Formatted code to enforce maximum line widths
b8e8dc7
@the-one-and-only-jackson
Fixed Box construction
889dbc5 
Promotion should happen regardless of conversion to StaticArray.
@the-one-and-only-jackson
Updated random sampling of Box
abe30f1 
For added consistency with gymnasium:
 - Finite intervals are sampled uniformly,
 - Infinite intervals are sampled normally,
 - Semi-infinite intervals are sampled as shifted exponential distributions.
@the-one-and-only-jackson
Update README.md
235fb1c
@the-one-and-only-jackson
Added HybridProductSpaceStyle
08644e5
@codecov
Copy link

codecov bot commented Jun 2, 2023 •
edited
Loading

Codecov Report

Merging #16 (578a191) into main (4fc19b0) will decrease coverage by 4.31%.
The diff coverage is 80.76%.

❗ Current head 578a191 differs from pull request most recent head e3fd034. Consider uploading reports for the commit e3fd034 to get more accurate results

@@            Coverage Diff             @@
##             main      #16      +/-   ##
==========================================
- Coverage   85.88%   81.57%   -4.31%     
==========================================
  Files           4        4              
  Lines          85      114      +29     
==========================================
+ Hits           73       93      +20     
- Misses         12       21       +9
Impacted Files Coverage Δ
src/CommonRLSpaces.jl 100.00% <ø> (ø)
src/array.jl 85.24% <76.31%> (-14.76%) ⬇️
src/basic.jl 77.77% <83.33%> (+1.30%) ⬆️
src/product.jl 76.47% <100.00%> (+2.27%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@the-one-and-only-jackson