Fix python3+osx tests on Travis #163
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, osx on Travis runs Python 2 even when the intention was to run the tests with Python 3. See: https://travis-ci.org/JuliaPy/pyjulia/jobs/373733201#L256 This is likely because: > `python` points to Homebrew’s Python 2.7.x (if installed) otherwise > the macOS system Python. > -- https://docs.brew.sh/Homebrew-and-Python This patch forces tests to run with whatever specified by `PYTHON` environment variable. This also let PyCall's build script to use the Python executable specified.
tkf
commented
May 18, 2018
.travis.yml
Outdated
| - if [ "$TRAVIS_OS_NAME" = "osx" -a "$PYTHON" = "python3" ]; then brew update; brew list python &>/dev/null || brew upgrade python || echo "Ignoring errors..."; fi | ||
| - if [ "$TRAVIS_OS_NAME" = "osx" -a "$PYTHON" = "python2" ]; then brew update; brew list python@2 &>/dev/null || brew install python@2 || echo "Ignoring errors..."; fi | ||
| - ls /usr/local/bin/py* | ||
| - for p in /usr/local/bin/python*; do echo $p; $p --version; done |
There was a problem hiding this comment.
Note:
$ ls /usr/local/bin/py*
/usr/local/bin/pydoc2 /usr/local/bin/python2
/usr/local/bin/pydoc2.7 /usr/local/bin/python2-config
/usr/local/bin/pyenv /usr/local/bin/python2.7
/usr/local/bin/pyenv-install /usr/local/bin/python2.7-config
/usr/local/bin/pyenv-uninstall /usr/local/bin/pythonw2
/usr/local/bin/python-build /usr/local/bin/pythonw2.7
before_script.9
0.26s$ for p in /usr/local/bin/python*; do echo $p; $p --version; done
/usr/local/bin/python-build
python-build 20160602
/usr/local/bin/python2
Python 2.7.14
/usr/local/bin/python2-config
Usage: /usr/local/bin/python2-config [--prefix|--exec-prefix|--includes|--libs|--cflags|--ldflags|--help]
/usr/local/bin/python2.7
Python 2.7.14
/usr/local/bin/python2.7-config
Usage: /usr/local/bin/python2.7-config [--prefix|--exec-prefix|--includes|--libs|--cflags|--ldflags|--help]
/usr/local/bin/pythonw2
Python 2.7.14
/usr/local/bin/pythonw2.7
Python 2.7.14
https://travis-ci.org/JuliaPy/pyjulia/jobs/380142002#L2485
with tkf@d0ae064
|
@tkf I now have access to this repo, so I'm going to go ahead and merge! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, osx on Travis runs Python 2 even when the intention was to run the tests with Python 3. See:
https://travis-ci.org/JuliaPy/pyjulia/jobs/373733201#L256
#149 (comment)
This is likely because:
This patch forces tests to run with whatever specified by
PYTHONenvironment variable. This also let PyCall's build script to use the Python executable specified.