Skip to content

Strip whitespace before parsing in seval #380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 11, 2023
Merged

Strip whitespace before parsing in seval #380

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b88ae7e
strip whitespace before parsing in seval
Oct 10, 2023
2ee2bb5
add seval tests
Oct 10, 2023
bef8c6a
move tests to python
Oct 10, 2023
902b033
move back to Julia side :(
Oct 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions test/utils.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,3 +11,9 @@ end
@test s[1:2] == "ab"
@test s[1:2:end] == "aaaab"
end

@testitem "seval" begin
m = Py(Main)
@test m.seval("1 + 1") === 2 # Basic behavior
@test m.seval("1 + 1\n ") === 2 # Trailing whitespace
end
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you move the test to

PythonCall.jl/test/jlwrap.jl

Line 189 in 5f56a9b

@testitem "module" begin
please?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also these tests are failing because m.seval(...) returns a Py.