Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deprecated methods #590

Merged
merged 2 commits into from
Jul 6, 2024
Merged

Update deprecated methods #590

merged 2 commits into from
Jul 6, 2024

Conversation

henry2004y
Copy link
Contributor

I noticed the following warning while using PyPlot:

┌ Warning: `haskey(o::PyObject, s::Union{Symbol, AbstractString})` is deprecated, use `hasproperty(o, s)` instead.
│   caller = init_colormaps() at colormaps.jl:57
└ @ PyPlot C:\Users\hyzho\.julia\packages\PyPlot\OOWfD\src\colormaps.jl:57

This PR updates the methods accordingly.

@codecov-commenter
Copy link

codecov-commenter commented Jul 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 23.83%. Comparing base (cb34a10) to head (5bbd31d).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #590   +/-   ##
=======================================
  Coverage   23.83%   23.83%           
=======================================
  Files           4        4           
  Lines         365      365           
=======================================
  Hits           87       87           
  Misses        278      278           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stevengj
Copy link
Member

stevengj commented Jul 6, 2024

Whoops, thanks

@stevengj stevengj merged commit efbead9 into JuliaPy:master Jul 6, 2024
4 of 6 checks passed
@henry2004y henry2004y deleted the patch-1 branch July 6, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants