Update deprecated colormap APIs #583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevengj
reviewed
May 23, 2024
Co-authored-by: Steven G. Johnson <[email protected]>
|
Minor bump:) Are we satisfied with this, or more tweaks/tests are required? |
stevengj
reviewed
Jun 10, 2024
|
Probably PythonPlot.jl needs a similar PR? |
|
Do we need to release a patch soon since this is affecting the usage of PyPlot.jl with Matplotlib 3.9? |
timholy
added a commit
to timholy/PyPlot.jl
that referenced
this pull request
Jul 2, 2024
Given JuliaPy#583, I think a minor bump might be warranted. Presumably fixes doctest failures like this SnoopCompile one: https://github.com/timholy/SnoopCompile.jl/actions/runs/9759104755/job/26935099642?pr=386
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to fix #582 by using the new APIs in Matplotlib 3.9 (which was deprecated since 3.6). I am not sure is the wrapper functions on the PyPlot side should also be renamed. I have not tested this locally since I don't know how to smoothly switch matplotlib versions without affecting my current environment...