Support closing the first (root) window in Tk #591
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevengj
reviewed
Oct 13, 2018
src/gui.jl
Outdated
| _tkinter = pyimport("_tkinter") | ||
| end | ||
| flag = _tkinter[:ALL_EVENTS] | _tkinter[:DONT_WAIT] | ||
| root = Tk["_default_root"] |
Member
There was a problem hiding this comment.
Probably just root = PyObject(nothing) since it will get updated in the event loop anyway.
stevengj
reviewed
Oct 13, 2018
| end | ||
| if root.o != pynothing[] | ||
| pycall(root["update"], PyObject) | ||
| while pycall(root["dooneevent"], Bool, flag) |
Member
There was a problem hiding this comment.
Oh, I see, it's "do one event"
Note: _tkinter is available both in Python 3 and 2. * https://docs.python.org/3/library/tkinter.html#tkinter-modules * https://docs.python.org/2/library/tkinter.html#tkinter-modules * https://github.com/ipython/ipython/blob/5.8.0/IPython/terminal/pt_inputhooks/tk.py#L45
Member
Author
|
OK. Applied the fix. |
Member
|
Why the change from |
Member
Author
|
Right, I should have left comments. Calling julia> using PyCall, PyPlot
julia> figure(1)
plot([1,2,3])
figure(2)
plot([1,2,3])
root = pyimport("tkinter")["_default_root"]
close(1)
julia> pycall(root["update"], PyObject)
ERROR: PyError ($(Expr(:escape, :(ccall(#= /home/takafumi/.julia/dev/PyCall/src/pyfncall.jl:44 =# @pysym(:PyObject_Call), PyPtr, (PyPtr, PyPtr, PyPtr), o, pyargsptr, kw))))) <class '_tkinter.TclError'>
TclError('can\'t invoke "update" command: application has been destroyed')
File "/usr/lib64/python3.7/tkinter/__init__.py", line 1174, in update
self.tk.call('update')I used It seems that So I guess that's why it works even after the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe fix JuliaPy/PyPlot.jl#316