-
Notifications
You must be signed in to change notification settings - Fork 187
Segfault with Python 3.7 #540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
64efd17 to
2b7ab9e
Compare
|
So in all platforms and all Julia versions, we have segfaults. |
|
Just applying the change in I didn't touch anything else to add full support of the new C APIs: https://docs.python.org/3/whatsnew/3.7.html#c-api-changes |
|
Actually, |
.travis.yml
Outdated
| - julia --color=yes -e 'VERSION < v"0.7.0-DEV.5183" || using Pkg; Pkg.add("Conda")' | ||
| - if [ "x$PYTHON" = xConda ]; then | ||
| julia --color=yes -e 'using Conda; Conda.add("python=3.7")'; | ||
| fi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd rather test the default for Conda here.
Maybe change AppVeyor to test Python 3.7 instead of Python 3.4, now that appveyor/ci#2475 made the former available.
|
Thanks for looking into this! |
|
Right, I agree that testing against the default Conda.jl setup is important. I changed Python 3 version in appveyor.yml as you suggested. If #543 CI fails and CI here succeeds, I think it's good to go. |
Codecov Report
@@ Coverage Diff @@
## master #540 +/- ##
==========================================
- Coverage 52.26% 51.39% -0.87%
==========================================
Files 19 19
Lines 1502 1502
==========================================
- Hits 785 772 -13
- Misses 717 730 +13
Continue to review full report at Codecov.
|
|
I rebased this PR onto #544 as it looks like previously tests in x64 AppVeyor were not run properly. The tests were actually run against Python installed via conda since binary incompatibility was automatically detected. Now that I fixed it, Python 3.7 in both x86 and x64 correctly segfault in #544. So this PR should be good to go once the tests here all pass. |
Running tests with Python 3.7 segfaults. I try to reproduce the issue on Travis in this PR.
The minimal code I found to cause the segfault was:
Added: closes #544