Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #271 #272

Merged
merged 2 commits into from
May 17, 2016
Merged

Fix #271 #272

merged 2 commits into from
May 17, 2016

Conversation

cstjean
Copy link
Collaborator

@cstjean cstjean commented May 17, 2016

When I translated the IO code to @pydef, I neglected to bring in that check from the jl_io_flush function.

@stevengj
Copy link
Member

Add a test case using PyObject(IOBuffer())[:flush]()?

@coveralls
Copy link

coveralls commented May 17, 2016

Coverage Status

Coverage increased (+0.1%) to 59.511% when pulling 31a80a2 on cstjean:pull-request/31a80a21 into 71495c1 on stevengj:master.

@cstjean
Copy link
Collaborator Author

cstjean commented May 17, 2016

Like this?

@stevengj
Copy link
Member

Great, thanks.

@stevengj
Copy link
Member

I've added you as a collaborator; feel free to merge when the tests are green.

@stevengj
Copy link
Member

And feel free to tag as a new patch release (1.6.1, I think).

@coveralls
Copy link

coveralls commented May 17, 2016

Coverage Status

Coverage increased (+0.1%) to 59.511% when pulling a551fa2 on cstjean:pull-request/31a80a21 into 71495c1 on stevengj:master.

@cstjean cstjean merged commit 802a18d into JuliaPy:master May 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants