Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parsing for datetime.time #1069

Merged
merged 3 commits into from
Mar 11, 2024
Merged

Add parsing for datetime.time #1069

merged 3 commits into from
Mar 11, 2024

Conversation

nateybear
Copy link
Contributor

Using same patterns as elsewhere in this file (and avoiding timezones like in DateTime), add support for parsing times from the Python datetime package to Julia's Dates.Time struct. This came up as a need I had in a personal project and was a quick addition.

Using same patterns as elsewhere in this file (and avoiding timezones like in DateTime), add support for parsing times from the Python datetime package to Julia's Dates.Time struct
@stevengj
Copy link
Member

Looks good. Could you add a couple of tests?

@codecov-commenter
Copy link

codecov-commenter commented Dec 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d407513) 67.75% compared to head (c74af34) 68.02%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1069      +/-   ##
==========================================
+ Coverage   67.75%   68.02%   +0.27%     
==========================================
  Files          20       20              
  Lines        2025     2036      +11     
==========================================
+ Hits         1372     1385      +13     
+ Misses        653      651       -2     
Flag Coverage Δ
unittests 68.02% <100.00%> (+0.27%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nateybear
Copy link
Contributor Author

nateybear commented Dec 17, 2023

Looks good. Could you add a couple of tests?

I added a rountripeq test like for Date and DateTime

ETA: added @test_throws to satisfy coverage checker too

@nateybear
Copy link
Contributor Author

@stevengj bumping since I also forgot about this. Tests have been implemented, check failures seem unrelated to this change.

@stevengj stevengj merged commit 2f600fb into JuliaPy:master Mar 11, 2024
16 of 18 checks passed
@stevengj
Copy link
Member

Looks good, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants