This repository was archived by the owner on Jul 13, 2021. It is now read-only.
Overload convert_arguments for LineString#479
Closed
Sov-trotter wants to merge 4 commits intoJuliaPlots:masterfrom
Closed
Overload convert_arguments for LineString#479Sov-trotter wants to merge 4 commits intoJuliaPlots:masterfrom
Sov-trotter wants to merge 4 commits intoJuliaPlots:masterfrom
Conversation
Contributor
Author
|
Also I was wondering, what is the correct way to support a vector of defined geometries. One way is iterating manually, but how can that be achieved via |
asinghvi17
reviewed
Aug 8, 2020
Overload for MultiLineString
Contributor
Author
|
@SimonDanisch @asinghvi17 can you take a look? |
Contributor
Author
|
decompose(PB, LineString) depends on JuliaGeometry/GeometryBasics.jl#73 |
This was referenced Aug 9, 2020
Contributor
Author
|
What changes might go in here, as we are moving towards JuliaGeometry/GeometryBasics.jl#80 in GeometryBasics? |
Member
|
continued in: #489 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the very first attempt at supporting GeometryBasics geometries based on MakieOrg/Makie.jl#660. Is there any better method to get to points? A set of decompose/reinterpret methods?