Remove UnitfulIntegration.jl from README#578
Merged
giordano merged 1 commit intoJuliaPhysics:masterfrom Mar 5, 2024
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #578 +/- ##
=======================================
Coverage 87.92% 87.92%
=======================================
Files 16 16
Lines 1449 1449
=======================================
Hits 1274 1274
Misses 175 175 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Collaborator
Author
|
I just noticed that infinite integration limits don’t work, so the statement that QuadGK supports Unitful quantities is not correct (infinite integration limits were supported by UnitfulIntegration.jl): julia> quadgk(x->exp(-x/(1.0m)), 0.0m, Inf*m)
ERROR: DomainError with Inf m:
integrand produced NaN m in the interval (0.0 m, Inf m)
Stacktrace:
[...]So we should either bring UnitfulIntegration.jl up to date or make a PR to QuadGK to support infinite quantities as integration limits. |
Member
|
That seems to be working now: julia> using QuadGK, Unitful
julia> quadgk(x->exp(-x/(1.0u"m")), 0.0u"m", Inf*u"m")
(1.0 m, 4.507382674563286e-11 m) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UnitfulIntegration.jl is also no longer needed, QuadGK can handle Unitful quantities since QuadGK v2.1.0.
I decided to remove the entry (instead of declaring it deprecated like UnitfulRecipes.jl) because it cannot even be installed with Unitful 1.x (it requires Unitful 0.x), so it isn’t relevant to the package in its current state.
Closes #376.