make measurements work with at-printf #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giordano
approved these changes
Apr 8, 2021
src/Measurements.jl
Outdated
| @@ -24,6 +24,8 @@ module Measurements | |||
| # Calculus is used to calculate numerical derivatives in "@uncertain" macro. | |||
| using Calculus | |||
|
|
|||
| import Printf | |||
There was a problem hiding this comment.
Good point. Done in 8af7314
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I implemented specializations of
Printf.tofloatto allow printing (the value of)Measurements. This is useful when working with functions that print some information during the computation, cf. https://discourse.julialang.org/t/forwarddiff-jl-and-printf/57694. This approach is also used in ForwardDiff.jl, cf. JuliaDiff/ForwardDiff.jl#511.The basic reasoning for this is that
Measurement's identify asAbstractFloats, which areReals. Hence, they can (and will) be used in quite general contexts where real numbers can appear. If someone implements a numerical algorithm in generic Julia code that can take quite some time and does not need to make use of Measurements.jl directly, they might have some intermediate printing statements to inform the user about the progress. Hence, it would be really nice ifMeasurements could still be used within such generic code written forRealnumbers.Closes #101