Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Groupby reduce with string grouping keys fix #24

Merged
merged 1 commit into from
Jan 29, 2023

Conversation

krynju
Copy link
Member

@krynju krynju commented Jan 29, 2023

a = DTable((a=rand(["abc", "bcd", "efg"], 100), b=rand(100)), 11)
r = fetch(reduce((x, y) -> x + y, DTables.groupby(a, :a), cols=[:b], init=0))

it would return r.a = ['a', 'b', 'e']

@codecov-commenter
Copy link

codecov-commenter commented Jan 29, 2023

Codecov Report

Base: 95.85% // Head: 95.99% // Increases project coverage by +0.13% 🎉

Coverage data is based on head (c5e5ac8) compared to base (39ef120).
Patch coverage: 100.00% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #24      +/-   ##
==========================================
+ Coverage   95.85%   95.99%   +0.13%     
==========================================
  Files          10       11       +1     
  Lines         820      823       +3     
==========================================
+ Hits          786      790       +4     
+ Misses         34       33       -1     
Impacted Files Coverage Δ
src/operations/operations.jl 98.50% <100.00%> (+0.04%) ⬆️
src/DTables.jl 100.00% <0.00%> (ø)
src/table/dtable.jl 92.85% <0.00%> (+0.79%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@krynju krynju merged commit d1eed4e into main Jan 29, 2023
@krynju krynju deleted the kr/groupbyreduce-index-fix branch January 29, 2023 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants