Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DTableColumn improvements #12

Merged
merged 4 commits into from
Sep 15, 2022
Merged

DTableColumn improvements #12

merged 4 commits into from
Sep 15, 2022

Conversation

krynju
Copy link
Member

@krynju krynju commented Aug 14, 2022

DTableColumn implementation was pretty rushed, so addressing the debt

@codecov-commenter
Copy link

codecov-commenter commented Aug 14, 2022

Codecov Report

Merging #12 (de93a0e) into main (826abbe) will increase coverage by 2.16%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #12      +/-   ##
==========================================
+ Coverage   88.29%   90.45%   +2.16%     
==========================================
  Files          10       10              
  Lines         846      828      -18     
==========================================
+ Hits          747      749       +2     
+ Misses         99       79      -20     
Impacted Files Coverage Δ
src/table/dataframes_interface.jl 64.81% <ø> (ø)
src/table/dtable.jl 84.44% <100.00%> (ø)
src/table/dtable_column.jl 100.00% <100.00%> (+35.71%) ⬆️
src/table/operations.jl 98.30% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ExpandingMan
Copy link

Do you still want to merge this? Thought I'd just bump in case I want to start looking into the package, thanks!

@krynju
Copy link
Member Author

krynju commented Sep 9, 2022

Yeah I am. I think it's even ready to merge.
I'll check tomorrow/Sunday and merge if nothing is left to add

This is just some under the hood changes and code cleanup of the dataframes select functionality (emulating full column functions like mean etc)
This doesn't introduce anything new, but I had to clean this up since I left it in a pretty bad shape 🥲

@krynju krynju marked this pull request as ready for review September 15, 2022 17:56
@krynju krynju merged commit 92a9149 into main Sep 15, 2022
@krynju krynju deleted the kr/dtablecolumn-improvements branch September 15, 2022 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants