Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache chunk sizes #43

Closed
krynju opened this issue Aug 10, 2023 · 0 comments · Fixed by #49
Closed

Cache chunk sizes #43

krynju opened this issue Aug 10, 2023 · 0 comments · Fixed by #49
Labels
good first issue Good for newcomers

Comments

@krynju
Copy link
Member

krynju commented Aug 10, 2023

We could sometimes speed up the chunk sizes fetch since the dtables are immutable for now anyway and if we get mutability we can just invalidate or change the field too
@krynju krynju added the good first issue Good for newcomers label Aug 10, 2023
@harsharora21 harsharora21 mentioned this issue Aug 23, 2023
Merged
@krynju krynju closed this as completed in #49 Sep 4, 2023
krynju pushed a commit that referenced this issue Sep 4, 2023
@harsharora21
Add caching for chunk sizes (#49)
94d66ed 
This PR fixes #43. It adds an extra field `chunk_lengths` to DTable.
This is used by `chunk_lengths` function for caching. This code assumes
DTables are immutable and sizes don't change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add caching for chunk sizes harsharora21/DTables.jl
1 participant
@krynju