add ffmpeg builders #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giordano
reviewed
Sep 18, 2019
| --dep-cc="${CC}" \ | ||
| --ar="${AR}" \ | ||
| --nm="${NM}" \ | ||
| --objcc="${CC} -ObjC" \ |
There was a problem hiding this comment.
There is the OBJC environment variable now
Co-Authored-By: Mosè Giordano <[email protected]>
|
Hey Simon, could you split these up into slightly smaller PRs? I will be happy to start with the simpler ones, like |
giordano
added
the
multimedia 🎧
|
How can I help to move this along? I'm happy to start breaking out some of the individual dependencies into individual PR's. |
|
I've removed from this PR |
|
Great! Do those remaining dependencies need to be split up into separate PR's? Can I help? |
|
@haberdashPI Yes, if you can take individual builders one by one and open PRs with each of them, that would help me. :) |
This was referenced Oct 22, 2019
Merged
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added an
add_builderscript for this purpose... I can remove it, but maybe it's helpful to also upgrade other builders?This is mostly auto generated, so will need to review this PR a bit!