Skip to content

fix(cuda.jl): use Base.thisminor#8691

Merged
maleadt merged 1 commit intoJuliaPackaging:masterfrom
characat0:patch-1
May 16, 2024
Merged

fix(cuda.jl): use Base.thisminor#8691
maleadt merged 1 commit intoJuliaPackaging:masterfrom
characat0:patch-1

Conversation

@characat0
Copy link
Contributor

@characat0 characat0 commented May 16, 2024

This is blocking cuda builds

ERROR: LoadError: UndefVarError: thisminor not defined
Stacktrace:
 [1] supported_platforms(; min_version::VersionNumber, max_version::Nothing)
   @ Main.CUDA /cache/build/yggy-amdci7-4/julialang/yggdrasil/platforms/cuda.jl:171

@characat0 characat0 mentioned this pull request May 16, 2024
Merged
@ViralBShah
Copy link
Member

ViralBShah commented May 16, 2024

cc @maleadt

maleadt
maleadt approved these changes May 16, 2024
View reviewed changes
Copy link
Member

@maleadt maleadt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@maleadt maleadt added the cuda 🕹️ Builders related to Nvidia CUDA label May 16, 2024
@maleadt maleadt merged commit bdd77f6 into JuliaPackaging:master May 16, 2024
amontoison pushed a commit that referenced this pull request Jun 22, 2024
@characat0 @amontoison
Fix missing import in CUDA platform augmentation (#8691)
4bb146e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maleadt maleadt maleadt approved these changes

Assignees

No one assigned

Labels

cuda 🕹️ Builders related to Nvidia CUDA

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@characat0 @ViralBShah @maleadt