Remove indirect MbedTLS_jll dependency from a few packages #8386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giordano
force-pushed
the
mg/rm-mbedtls
branch
4 times, most recently
from
ab950ff
to
2401e56
Compare
|
This is finally all green! I need to double check mbedtls was effectively removed everywhere, but at a quick glance this seems to be working as advertised, and without having to have newer builds of libgit2/libcurl/libssh2 without mbedtls. |
Co-authored-by: Mosè Giordano <[email protected]>
Co-authored-by: Mosè Giordano <[email protected]>
Also, require GCC 5 to make build work on x86_64-linux-gnu. Co-authored-by: Mosè Giordano <[email protected]> sam
Co-authored-by: Mosè Giordano <[email protected]>
That was completely wrong. Co-authored-by: Mosè Giordano <[email protected]>
Also, require GCC 5 to get the right version of glibc (2.17) in the build environment.
This reverts commit f99c7f9. We will build this in a follow-up PR, after new NetCDFF build is out.
|
Alright, I verified that all the packages in this PR were clean from linking to mbedtls libraries, so this is good to go. @fxcoudert thanks a lot for kickstarting this, it was extremely helpful! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@fxcoudert I'm taking out of #8377 the commits which are only removing the unneeded dependency of MbedTLS from some packages, so that we can keep there only switching to OpenSSL for julia's stdlibs. The two changesets are independent, what we have here doesn't require changing the SSL backend for the other packages.
This also reduces CI time, when I push new commits.