Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lower compatibility limit for bitshuffle. #5111

Closed
wants to merge 1 commit into from

Conversation

jamesrhester
Copy link
Contributor

The lower limit for Julia compatibility for bitshuffle was set to 1.6, however HDF5.jl (the main user of this library) supports 1.3.

Copy link
Member

@giordano giordano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You know Julia v1.6 is the current LTS, right? And that also HDF5_jll requires Julia v1.6:

build_tarballs(ARGS, name, version, sources, script, platforms, products, dependencies; julia_compat="1.6")

And the compat can't really be changed, especially without changing the version number of the package itself, there is no way I'm going to accept this PR in the current status anyway.

@jamesrhester
Copy link
Contributor Author

OK, I'm just trying to do whatever has to be done to get the filter into HDF5. I'll see what the HDF5 people have to say about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants