Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LERC compression to libtiff #4538

Merged
merged 2 commits into from
Mar 3, 2022
Merged

Conversation

evetion
Copy link
Contributor

@evetion evetion commented Mar 3, 2022

@Crghilardi added LERC to Yggdrasil 👍🏻. Ping to @visr because of #4537 which can be closed if this works.

@evetion
Copy link
Contributor Author

evetion commented Mar 3, 2022

From my quick checks this seems to work:
[13:50:38] LERC support: yes

Exception is the latest macs, there we have
##[warning]Dependency LERC_jll does not have a mapping for artifact LERC for platform aarch64-apple-darwin20-libgfortran5-cxx11 which probably needs to be solved in LERC_jll itself. edit: I've made #4539 for that.

@giordano
Copy link
Member

giordano commented Mar 3, 2022

Yeah, you may want to rebuild LERC_jll before this one

@evetion
Copy link
Contributor Author

evetion commented Mar 3, 2022

@giordano Could you restart the CI here? I'd expect it will pick up LERC v3.0.0+1 automatically now, we don't want to pin that here.

@evetion evetion mentioned this pull request Mar 3, 2022
@giordano
Copy link
Member

giordano commented Mar 3, 2022

Not before JuliaRegistries/General#55890 is merged. Also, we can't just restart CI, you have to make a dummy edit to the file to actually retrigger the build, if nothing changes we reuse the cache from the previous build.

@evetion
Copy link
Contributor Author

evetion commented Mar 3, 2022

edit: I've been ninja-ed by @giordano again. 👍🏻

@giordano giordano merged commit 2e25f4f into JuliaPackaging:master Mar 3, 2022
@evetion evetion deleted the patch-5 branch March 3, 2022 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants