Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wizard recipe: SDL2_gfx-v1.0.3 #438

Merged
merged 6 commits into from
Jan 27, 2020

Conversation

aviks
Copy link
Contributor

@aviks aviks commented Jan 26, 2020

This pull request contains a new build recipe I built using the BinaryBuilder.jl wizard:

  • Package name: SDL2_gfx
  • Version: v1.0.3

@staticfloat please review and merge.

@aviks aviks requested a review from giordano January 26, 2020 21:44
@giordano
Copy link
Member

giordano commented Jan 26, 2020

Looks like they're expecting only x86 architectures. I'm on it.

@giordano
Copy link
Member

Should now work for ARM architectures, still need to fix some problems on PowerPC and FreeBSD

@aviks
Copy link
Contributor Author

aviks commented Jan 26, 2020

Thanks! There seem to be some linker errors on windows that I also do not understand.

@giordano
Copy link
Member

giordano commented Jan 27, 2020

I have the feeling that the remaining issues are all related to the very old build system of the package. If only we were able to rebuild the configure script...

Edit: well, there was a missing line in configure.in... 🙄

@giordano giordano force-pushed the wizard/SDL2_gfx-v1.0.3_8731f840 branch from 1e4f251 to 9bec597 Compare January 27, 2020 01:29
@giordano
Copy link
Member

giordano commented Jan 27, 2020

I didn't want to spend more time on investigating the problem and since this is very simple I just went with manually building the shared library out of the static archive.

@giordano giordano merged commit d700c94 into JuliaPackaging:master Jan 27, 2020
@giordano giordano deleted the wizard/SDL2_gfx-v1.0.3_8731f840 branch January 27, 2020 01:37
@giordano giordano removed their request for review January 27, 2020 01:53
@giordano
Copy link
Member

For the record, most of the issues we found here are similar to what we had in #123. Also for Windows, the link problem is the same as the one reported in #123 (comment), and also the solution was the same: manually build the shared library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants