This repository has been archived by the owner on Aug 16, 2023. It is now read-only.
Fix install function #209
Open
Fix install function #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #190,
installwas broken due to some missing imports. Also, the behaviour ofunpackseems to have changed: it now errors when used this way, because the target directory is required to be empty. I've added an unzip to a temporary directory in order to replicate the old behaviour.I haven't checked for other uses of
unpack, which may also need fixing, or for other missing imports; this just fixes one particular build script I have.