Skip to content
This repository has been archived by the owner on Aug 16, 2023. It is now read-only.

Fallback to __FILE__ when initializing global_prefix #156

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tkf
Copy link

@tkf tkf commented Apr 10, 2019

pathof(@__MODULE__) cannot be used to find the module path reliably due to JuliaLang/julia#31662. I suggest to fallback to @__FILE__.

Alternatively, a much simpler solution would be to use @__DIR__

global_prefix = Prefix(joinpath(@__DIR__, "..", "global_prefix"))

but this would decrease relocatability #126.

@codecov-io
Copy link

codecov-io commented Apr 10, 2019

Codecov Report

Merging #156 into master will decrease coverage by 0.11%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #156      +/-   ##
==========================================
- Coverage   56.83%   56.71%   -0.12%     
==========================================
  Files           9        9              
  Lines        1010     1012       +2     
==========================================
  Hits          574      574              
- Misses        436      438       +2
Impacted Files Coverage Δ
src/BinaryProvider.jl 60% <33.33%> (-40%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 530fb35...dc1bac6. Read the comment docs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants