Skip to content
This repository has been archived by the owner on Aug 16, 2023. It is now read-only.

Check powershell version number #132

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

simonbyrne
Copy link
Contributor

Alternative fix for #127

@codecov-io
Copy link

codecov-io commented Oct 16, 2018

Codecov Report

Merging #132 into master will decrease coverage by 31.54%.
The diff coverage is 9.09%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #132       +/-   ##
===========================================
- Coverage    88.4%   56.86%   -31.55%     
===========================================
  Files           8        9        +1     
  Lines         647     1013      +366     
===========================================
+ Hits          572      576        +4     
- Misses         75      437      +362
Impacted Files Coverage Δ
src/PlatformEngines.jl 43.01% <9.09%> (-29.12%) ⬇️
src/LoggingUtils.jl 50% <0%> (-50%) ⬇️
src/CompatShims.jl 33.33% <0%> (-33.34%) ⬇️
src/PlatformNames.jl 65.17% <0%> (-30.8%) ⬇️
src/Products.jl 67.22% <0%> (-29.12%) ⬇️
src/Prefix.jl 67.16% <0%> (-24.06%) ⬇️
src/OutputCollector.jl 75.86% <0%> (-17.83%) ⬇️
src/precompile.jl 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb403e6...2b23b46. Read the comment docs.

@simonbyrne
Copy link
Contributor Author

Wait: do we bundle busybox with windows? Why aren't we just using that!

@simonbyrne
Copy link
Contributor Author

Well, I don't know what I broke on linux, but this fixes the Windows issues since it will now fall back on the busybox wget on Win 7.

@staticfloat
Copy link
Member

I'm not sure why this would be failing; my best guess is that your change to probe_cmd() is causing it to think it can't find sh on Travis. I can't reproduce it locally though. :/

@simonbyrne
Copy link
Contributor Author

I think the problem is that dash shell (the default sh on Ubuntu) doesn't accept --version as an argument.

@simonbyrne
Copy link
Contributor Author

I mean --help.

@simonbyrne
Copy link
Contributor Author

Ah, that fixed it!

visr pushed a commit to visr/BinaryProvider.jl that referenced this pull request May 10, 2019
* Add "privileged container" mode to `sandbox.c`

On some Linux kernels, mounting overlay filesystems within user
namespaces is broken, see [0] for an Ubuntu issue tracking this and
their patch to fix it. To work around this, we allow the user to enable
running the sandbox through `sudo`, which adds another path through the
already convoluted `sandbox.c`.  After a thorough reorganization of
`sandbox.c`, we now have three well-defined execution modes (init,
unprivileged and privileged) and a `sandbox` that can either mount
overlay filesystems as root within a user namespace, or can mount
overlay filesystems as root outside of a user namespace, then enter the
user namespace.

[0] https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1531747

* Bump rootfs version

* Quash some small bugs
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants