[Prefix] Fix installation of packages in nightly#227
Merged
giordano merged 2 commits intoJuliaPackaging:masterfrom Mar 1, 2022
Merged
[Prefix] Fix installation of packages in nightly#227giordano merged 2 commits intoJuliaPackaging:masterfrom
giordano merged 2 commits intoJuliaPackaging:masterfrom
Conversation
Member
Author
|
Failure is It's the cleanup that is failing, very weird... |
With Julia v1.9 we have to use `Pkg.respect_sysimage_versions(false)` to install stdlib JLLs in our projects.
d272b18 to
28903a3
Compare
Changes in the new tarballs of LibCURL and other packages means that
`cleanup_dependencies` can't remove all directories. This is similar to the
problem we have already inside `${includedir}`.
Member
Author
|
The new builds of LibCURL and other related stdlib JLLs used in Julia v1.9 have logs in subdirectories of BinaryBuilderBase.jl/test/dependencies.jl Lines 158 to 159 in f78a16a cleanup_dependencies BinaryBuilderBase.jl/src/Prefix.jl Line 244 in f78a16a |
Member
Author
|
The only thing I don't understand is this: this job was successful and it used which was already after JuliaLang/julia#43250 was merged, so now I'm not sure why that one worked at it's failing only now with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With Julia v1.9 we have to use
Pkg.respect_sysimage_versions(false)to installstdlib JLLs in our projects.
Opening as draft because tests are failing anyway for me even with this change, but I don't have the time to debug now.