Allow disabling the isidentifier check in build_tarballs
#1282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giordano
approved these changes
Jun 8, 2023
|
It occurred to me that since #1117 removed the later name validation in favor of doing it early, adding the option to bypass validation here means that you may never validate the name. Not sure whether that's a bug or a feature of this PR but I figure it's worth noting. |
Validation of the field that will determine the name of the generated JLL package is what you want 99.9% of the time. But that other 0.1% of the time is `Yggdrasil/0_RootFS/PlatformSupport/build_tarballs.jl`: each invocation of the script specifies a separate platform, the triplet of which gets embedded in the name. Unfortunately e.g. `PlatformSupport-x86_64-unknown-freebsd13.2` is not a valid identifier, so building PlatformSupport with recent BinaryBuilder fails.
ararslan
force-pushed
the
aa/defer-name-check
branch
from
29c6cbd
to
61b8b01
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validation of the field that will determine the name of the generated JLL package is what you want 99.9% of the time. But that other 0.1% of the time is
Yggdrasil/0_RootFS/PlatformSupport/build_tarballs.jl: each invocation of the script specifies a separate platform, the triplet of which gets embedded in the name. Unfortunately e.g.PlatformSupport-x86_64-unknown-freebsd13.2is not a valid identifier, so building PlatformSupport with recent BinaryBuilder fails.