Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly import Libdl #120

Merged
merged 1 commit into from
Jan 29, 2018
Merged

Explicitly import Libdl #120

merged 1 commit into from
Jan 29, 2018

Conversation

staticfloat
Copy link
Member

JuliaLang/julia#25459 moved Libdl to the
stdlib, which means that we need to explicitly import it now before we
can do things like Libdl.dlopen().

JuliaLang/julia#25459 moved `Libdl` to the
stdlib, which means that we need to explicitly import it now before we
can do things like `Libdl.dlopen()`.
@codecov-io
Copy link

codecov-io commented Jan 15, 2018

Codecov Report

Merging #120 into master will increase coverage by 1.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #120      +/-   ##
==========================================
+ Coverage   31.98%   33.07%   +1.08%     
==========================================
  Files          15       15              
  Lines        1260     1412     +152     
==========================================
+ Hits          403      467      +64     
- Misses        857      945      +88
Impacted Files Coverage Δ
src/BinaryBuilder.jl 54.54% <ø> (-0.72%) ⬇️
src/QemuRunner.jl 0% <0%> (ø) ⬆️
src/RootFS.jl 53.89% <0%> (+0.28%) ⬆️
src/UserNSRunner.jl 83.58% <0%> (+2.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e79b441...1c4c01b. Read the comment docs.

@Keno Keno merged commit f7e7e89 into master Jan 29, 2018
@ararslan ararslan deleted the sf/import_libdl branch January 29, 2018 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants