-
Notifications
You must be signed in to change notification settings - Fork 34
Raise error when trying to visualize tree with enable_tree_vis=false
#98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportBase: 85.83% // Head: 86.12% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #98 +/- ##
==========================================
+ Coverage 85.83% 86.12% +0.28%
==========================================
Files 10 10
Lines 473 490 +17
==========================================
+ Hits 406 422 +16
- Misses 67 68 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
enable_tree_vis=true
enable_tree_vis=false
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution! This is a good change to make, but please see my comments in the code.
Oops I misunderstood something in my comment. It looks good if you change the error message like I suggested! |
Ok, thanks for the feedback, done! |
Thanks! |
Addresses #97