Skip to content

Put search_time in seconds in info #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 9, 2022

Conversation

johannes-fischer
Copy link
Contributor

To make it even more consistent with JuliaPOMDP/POMCPOW.jl#32.

I just found it annoying when switching back and forth between MCTS and POMCPOW that one provides :search_time and the other :search_time_us in the info dict.

@zsunberg
Copy link
Member

@johannes-fischer Thanks! I agree this is better. Waiting on the tests to pass. The question is, do we need to tag v0.5 after this since it is technically a breaking change?

@johannes-fischer
Copy link
Contributor Author

Good point! It seems that in POMCPOW you have not tagged a new minor version after the equivalent change, only a patch. I think is shouldn't be a big issue to fix for users, since it doesn't really change how you use MCTS, only how the result is represented (still somewhat part of the API though).
Alternatively it's also possible to provide both in info until the next minor version increment. But then it's probably easy to forget to remove it later on.

@zsunberg zsunberg merged commit af49676 into JuliaPOMDP:master Mar 9, 2022
@johannes-fischer johannes-fischer deleted the dev/timer branch January 30, 2023 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants