Reorganize source code and modules #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test this please |
|
Test this please |
williamfgc
reviewed
Mar 4, 2025
williamfgc
reviewed
Mar 4, 2025
williamfgc
reviewed
Mar 4, 2025
williamfgc
reviewed
Mar 4, 2025
williamfgc
reviewed
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #157 and #185 and #199
This PR (mostly) reorganizes the source tree to be more sensible (in my opinion) and follow conventions I see from other projects. Most of this has no effect on the API.
There are a couple changes to the API:
JACC.Multi.Array->JACC.Multi.arrayFunctions could be passed now takeBase.Callablewhich includes functor structsJACCPreferencesmodule. So users can access with justJACC.set_backend()andJACC.backendThe third change will break the CI (since the gpu workflow files use
JACCPreferences)