-
Notifications
You must be signed in to change notification settings - Fork 8
Make tau-2pi.svg dark-mode-friendly
#56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was going to ask whether the URL change would allow the image to continue working outside GitHub, e.g. on https://juliapackages.com/p/tau or https://juliahub.com/ui/Packages/General/Tau, but it turns out the current one already doesn't work, so we might even end up fixing that; and even if we don't, things won't get worse than they already are, so this looks like a strict improvement. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't realize the change could have the side effects you mentioned. I've noticed that packages like
Pluto.jlandFlux.jluse URLs pointing to raw.githubusercontent.com for their images. Given this, it seems prudent to revert this particular change. The correct URL should be: https://raw.githubusercontent.com/JuliaMath/Tau.jl/master/tau-2pi.svg. If you agree, I can submit a pull request to address this.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure reverting the change would fix the issue — the image was already broken with the previous URL. Do note, however, that it was a
rawgit.comURL rather than araw.githubusercontent.comone, so perhaps a change to the latter would indeed be beneficial. A PR to do that would be very welcome, but perhaps we should make a release first, to check if the simpler filename-only path works. WDYT, @giordano — would a patch release be OK for this?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, it's probably fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you mind making the release? 😅 I'm a bit rusty on the process as it's been a while. (Or just point me towards the relevant docs. Do we create a tag for a commit in this repo and TagBot handles the PR to the registry, or is it the other way around?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tau.jl/Project.toml
Line 3 in e951380
masterbranch which contains the bump, comment withThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After a small speed bump in #53 and #58, this has now been done via #57 — here's the commit: a74455e
Thanks for the help, @giordano!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rwnobrega it seems like the simple file path works! Both the README and https://juliahub.com/ui/Packages/General/Tau show the image. (https://juliapackages.com/p/tau still shows the broken image, but its cache hasn't been updated yet, because in the page source code I can see the the attribute
data-canonical-src="https://rawgit.com/JuliaMath/Tau.jl/master/tau-2pi.svg"in the<img>element, i.e. pointing to the URL prior to this PR and to the release of v2.0.1.) So I'd say we're good and there's no need for further changes! Thanks again for the contribution :)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great to hear that! Thank you as well. 😄