Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README: add testing badges #10

Merged
merged 3 commits into from
Jan 8, 2017
Merged

README: add testing badges #10

merged 3 commits into from
Jan 8, 2017

Conversation

waldyrious
Copy link
Collaborator

On hold until the tests are actually green

@waldyrious
Copy link
Collaborator Author

@waldyrious
Copy link
Collaborator Author

@Aerlinger, would you mind giving me the necessary permissions to set up Travis for this repo? It would be nice if we could test PRs before merging them.

@waldyrious
Copy link
Collaborator Author

Until the necessary tokens are set on this repo, here are the results using my fork:

Travis: Travis
Appveyor: Appveyor
Coveralls: Coveralls
Codecov: Codecov

@Aerlinger Aerlinger merged commit 87b98e9 into master Jan 8, 2017
@waldyrious
Copy link
Collaborator Author

@Aerlinger I was planning on not merging this until the services were actually configured. Are you going to set up Travis, Appveyor, etc for this repo? I can do that if you prefer, but I don't currently have the permissions to do so.

@waldyrious waldyrious deleted the test-badges branch January 8, 2017 01:29
@Aerlinger
Copy link
Collaborator

Aerlinger commented Jan 8, 2017 via email

@waldyrious
Copy link
Collaborator Author

You're right. Reading the help pages linked from https://help.github.com/articles/what-are-the-different-access-permissions/, it appears that the only way one more than one person can have access to the repository settings, is if the repository is under an organization.

At this point I'd bring up a proposal I made before: would you consider the possibility of getting Tau.jl under the umbrella of the @JuliaMath organization? I understand if you'd rather not, but I thought I'd make sure, since you haven't mentioned a preference either way so far.

@Aerlinger
Copy link
Collaborator

Aerlinger commented Jan 9, 2017 via email

@waldyrious
Copy link
Collaborator Author

Gee, I had forgotten about that detail. I never understood the reasoning for that, but in any case, I'm not in there either. Perhaps @tkelman could help us out -- he's been very helpful and responsive when I submitted the recent changes in this repo to METADATA.jl.

@tkelman
Copy link

tkelman commented Jan 9, 2017

Okay. Try not to mess with any of the other repos there without going through PR's etc. Github/Travis/etc permissions aren't the most granular things.

@Aerlinger
Copy link
Collaborator

Thanks @tkelman. I moved the repo just now.

@waldyrious
Copy link
Collaborator Author

waldyrious commented Jan 9, 2017

@tkelman could you invite me as well? I still don't have access to this repo's settings, and I'd like to set up the integrations for the remaining badges.

Nevermind, I seem to have gotten access meanwhile. Perhaps it was a sync issue on github.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants