Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix type-instability of logabsbeta #332

Merged
merged 2 commits into from
Jul 3, 2021
Merged

fix type-instability of logabsbeta #332

merged 2 commits into from
Jul 3, 2021

Conversation

stevengj
Copy link
Member

@stevengj stevengj commented Jul 2, 2021

Fixes #331.

Also omit an Int conversion for iseven in Julia ≥ 1.7 (JuliaLang/julia#38976)

@codecov
Copy link

codecov bot commented Jul 2, 2021

Codecov Report

Merging #332 (06ae64b) into master (5f0a078) will decrease coverage by 0.26%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #332      +/-   ##
==========================================
- Coverage   92.72%   92.46%   -0.27%     
==========================================
  Files          12       12              
  Lines        2653     2653              
==========================================
- Hits         2460     2453       -7     
- Misses        193      200       +7     
Flag Coverage Δ
unittests 92.46% <100.00%> (-0.27%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/gamma.jl 94.91% <100.00%> (ø)
src/beta_inc.jl 89.45% <0.00%> (-1.09%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f0a078...06ae64b. Read the comment docs.

@stevengj stevengj merged commit 42bb273 into master Jul 3, 2021
@stevengj stevengj deleted the logbeta_typefix branch July 3, 2021 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

logbeta is type-unstable
2 participants