Bisection error with Unitful

[tomyun]

using Roots
using Unitful
s = u"s"; m = u"m"
g = 9.8*m/s^2
v0 = 10m/s
y0 = 16m
y(t) = -g*t^2 + v0*t + y0
find_zero(y, 1s)
# 1.8860533706680143 s

Above example in README works as is. However, it fails when bisection method is used.

find_zero(y, (0s, 2s), Bisection())
# ERROR: DimensionError: 0.0 and 0.0 s are not dimensionally compatible.

Interestingly other methods work fine with the same bracket.

find_zero(y, (0s, 2s), FalsePosition())
find_zero(y, (0s, 2s), Roots.A42())
find_zero(y, (0s, 2s), Roots.AlefeldPotraShi())
# 1.8860533706680243 s

I guess it should have been caught in the test case if it was not commented out.

[jverzani]

Thanks for letting me know. I just pushed a fix to address this bug. But still should add Unitful to the test suite so that those tests run automatically.

[jverzani]

closed by #163