Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add is_, as_, isreal, real, isintegerpoly & asintegerpoly #259

Merged
merged 17 commits into from
Sep 10, 2020
Merged

Add is_, as_, isreal, real, isintegerpoly & asintegerpoly #259

merged 17 commits into from
Sep 10, 2020

Conversation

singularitti
Copy link
Contributor

Closes #258

@singularitti
Copy link
Contributor Author

singularitti commented Sep 8, 2020

We can rename isintegerpoly & asintegerpoly to isintegral & asintegral, what do you think? The names come from "integral polynomials", an alias of "integer polynomials". It is said that "integral polynomials" were deprecated but I think isintegral is less ambiguous than "isinteger" here.

Copy link
Member

@jverzani jverzani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isintegral is better than isintegerpoly.

src/common.jl Show resolved Hide resolved
src/common.jl Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Sep 8, 2020

Codecov Report

Merging #259 into master will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #259      +/-   ##
==========================================
+ Coverage   87.46%   87.52%   +0.05%     
==========================================
  Files          15       15              
  Lines        1500     1507       +7     
==========================================
+ Hits         1312     1319       +7     
  Misses        188      188              
Impacted Files Coverage Δ
src/common.jl 91.92% <100.00%> (+0.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 930b116...3195ea9. Read the comment docs.

src/common.jl Outdated Show resolved Hide resolved
@jverzani
Copy link
Member

Great and thanks! Once the tests go through, I'll get this merged in.

@jverzani jverzani merged commit d17ec51 into JuliaMath:master Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend isreal & real for Polynomial?
2 participants