support zero-arg parametric constructor for Constant and Linear #442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #442 +/- ##
==========================================
+ Coverage 84.78% 84.81% +0.02%
==========================================
Files 25 25
Lines 1643 1646 +3
==========================================
+ Hits 1393 1396 +3
Misses 250 250
Continue to review full report at Codecov.
|
|
Do we need a new release soon to address this? |
|
No need, I've fixed ImageTransformations by directly using the field value. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ImageTransformations uses
typeof(deg)()internally and it assumes the zero argument version constructorLinear{Throw{OnGrid}}()andConstant{Nearest,Throw{OnGrid}}()exist. So Interpolations v0.13.3 unfortunately breaks ImageTransformations 😢I'm not sure if the
bcfield is necessary. (See my comments in https://github.com/JuliaMath/Interpolations.jl/pull/428/files#r668457028). This patch assumes thatbcis needed and I added these constructor methods.JuliaImages/ImageTransformations.jl#132 fixes the issue in ImageTransformations side, but I believe this is still useful.